-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ✨ conversion webhook support in envtest #999
[WIP] ✨ conversion webhook support in envtest #999
Conversation
This adds support for CRD conversion webhooks in envtest. It functions similarly to how other webhook support works in envtest, and shares the underlying CA with any other webhooks that envtest knows about.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DirectXMan12: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Currently trying to test this out locally. If I can make sense of everything I can try to move this further along. We'll need a test for conversion webhooks in |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@DirectXMan12: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds support for CRD conversion webhooks in envtest. It functions
similarly to how other webhook support works in envtest, and shares the
underlying CA with any other webhooks that envtest knows about.
I'm not particularly happy with the structure of the "sharing CA between conversion and mutating/defaulting webhooks", but I didn't really want to expose the underlying internal CA machinery. I think probably we could make do with a few fewer pointers.
This is largely a prototype, and I'd be happy to pass this off to someone else to hack on.
Fixes #998