Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing windows library. #345

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

Random-Liu
Copy link
Contributor

@yujuhong @feiskyer When do release, I found that build on windows fails because of this.

I'll send another PR to add make release in travis.
Signed-off-by: Lantao Liu lantaol@google.com

Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 13, 2018
@Random-Liu Random-Liu added this to the v1.11.1 milestone Jul 13, 2018
@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2018
@Random-Liu Random-Liu merged commit aa52486 into kubernetes-sigs:master Jul 13, 2018
@Random-Liu Random-Liu deleted the add-missing-library branch July 13, 2018 01:10
Random-Liu referenced this pull request Jul 13, 2018
@feiskyer
Copy link
Member

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants