Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement password input on the command line #997

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Implement password input on the command line #997

merged 1 commit into from
Oct 6, 2022

Conversation

sgaist
Copy link
Contributor

@sgaist sgaist commented Oct 5, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Rather than writing full credentials on the command line when pulling an image this option allows user to pass a username and get asked for the password as can be done with the ssh command line application.

Which issue(s) this PR fixes:

Fixes #996

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added: enter password on the command line for pull related commands

A new option has been introduced to allow user to enter the registry password securely on the command line rather than as part of the command itself.

Example:
    crictl pull --username foobar registry.example.com/myimage:mytag

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sgaist!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 5, 2022
@saschagrunert
Copy link
Member

@haircommander PTAL

haircommander
haircommander reviewed Oct 5, 2022
View reviewed changes
cmd/crictl/image.go Outdated
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0
http://www.apache.org/licenses/LICENSE-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if you end up updating something, can you revert this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the boilerplate linter is failing because of this

Copy link
Contributor Author

@sgaist sgaist Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, it is something that was changed when I used one of go mod vendor or gofmt but running either of them again after reverting the change does not mention it anymore.

I was wrong, with my editor I saw that I used spaces in place of tabs as the surrounding code and applied a cleanup to be consistent with the rest of the file hence the change to that line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sgaist
Implement password input on the command line
4b984dd 
Rather than writing full credentials on the command line this option allows user
to pass a username and get asked for the password as can be done with the ssh
command line application.
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@haircommander: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sgaist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@saschagrunert
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 79e5c5b into kubernetes-sigs:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read password from the command line when pulling images
4 participants
@sgaist @k8s-ci-robot @saschagrunert @haircommander