Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Tests + Kustomize #829

Closed
jklaw90 opened this issue Jun 1, 2022 · 2 comments
Closed

Helm Tests + Kustomize #829

jklaw90 opened this issue Jun 1, 2022 · 2 comments

Comments

@jklaw90
Copy link
Contributor

jklaw90 commented Jun 1, 2022

If using kustomize to render the chart and add extra transformations you can't disable the tests with the normal --skip-tests, see issue.

We could add a helm value to get around this case (kind of odd), but in general i don't see much value form the test provided.
I just tested it locally and it "passed" while the image wasn't able to pull so i do wondering if we should remove the helm test or improve it to be more useful?

@jklaw90 jklaw90 changed the title Helm Tests Helm Tests + Kustomize Jun 1, 2022
@a7i
Copy link
Contributor

a7i commented Jun 2, 2022

@jklaw90 Curious why not use this directory for kustomize?

Agreed on improving the test. 👍🏼

@jklaw90
Copy link
Contributor Author

jklaw90 commented Jun 2, 2022

I like the naming flexibility the helm chart offers. I could probably look at alternatives to modify things after the render.

@jklaw90 jklaw90 closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants