Chart tests.enabled flag

[jklaw90]

If using kustomize to render the chart and add extra transformations you can't disable the tests with the normal --skip-tests see issue.
Just adding this this flag to get around this case.

[k8s-ci-robot]

Hi @jklaw90. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign seanmalloy after the PR has been reviewed.
You can assign the PR to them by writing /assign @seanmalloy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damemi]

/ok-to-test

[damemi]

This seems ok, but imo it's weird to set a flag to just disable the content of the entire file rather than omit the caller to the file in the first place. Have you tested this locally?

Also don't know why CI says "waiting for status to be reported"

[jklaw90]

yeah, i tested it locally works fine and i agree it is odd.
I wonder if kustomize doesn't care to support this case since helm tests are pretty rare.
Our test seems kind of unnecessary too, would it even pass for a cronjob that is deployed for the first time to a new cluster?

[damemi]

/ok-to-test

[damemi]

@jklaw90 sorry, I haven't forgotten about this (just had other stuff come up). I'm still not sure how I feel about this particular approach, and you bring up a good point about the helm tests too. So I'd like to look into those a bit more before going ahead with this. Is it a critical issue that's blocking kustomize users?

[jklaw90]

@damemi yeah, thats totally fine i can close this one out.

[damemi]

@jklaw90 could you open an issue so we can track it for now? Not saying this is a wontfix