fix: possible nil ptr for invalid records like too long name

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
kubernetes-sigs · Mar 2, 2024 · abf56c2 · abf56c2
1 parent 6cf4783
commit abf56c2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/provider/aws/aws.go b/provider/aws/aws.go
@@ -416,6 +416,9 @@ func (p *AWSProvider) records(ctx context.Context, zones map[string]*route53.Hos
 			}
 
 			for _, ep := range newEndpoints {
+				if ep == nil {
+					continue
+				}
 				if r.SetIdentifier != nil {
 					ep.SetIdentifier = aws.StringValue(r.SetIdentifier)
 					switch {

diff --git a/provider/aws/aws_test.go b/provider/aws/aws_test.go
@@ -353,6 +353,12 @@ func TestAWSRecords(t *testing.T) {
 			TTL:             aws.Int64(recordTTL),
 			ResourceRecords: []*route53.ResourceRecord{{Value: aws.String("8.8.8.8")}},
 		},
+		{
+			Name:            aws.String("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA.ext-dns-test-2.teapot.zalan.do."),
+			Type:            aws.String(route53.RRTypeA),
+			TTL:             aws.Int64(recordTTL),
+			ResourceRecords: []*route53.ResourceRecord{},
+		},
 		{
 			Name:            aws.String("*.wildcard-test.zone-2.ext-dns-test-2.teapot.zalan.do."),
 			Type:            aws.String(route53.RRTypeA),