Project Contour HTTPProxy support?

[vincentjorgensen]

contour-httpproxy isn't supported yet. Is there a way to get external-dns to honor httpproxy if set in the annotations. Sample below:

apiVersion: projectcontour.io/v1
kind: HTTPProxy
metadata:
  annotations:
    external-dns.alpha.kubernetes.io/hostname: grpc.megatron.sample.com
metadata:
  name: grpc-megatron
  namespace: development
spec:
  virtualhost:
    fqdn: grpc.megatron.sample.com
  routes:
    - conditions:
      - prefix: /
      services:
        - name: megatron
          protocol: h2c
          port: 10000

[njuettner]

@vincentjorgensen probably you need to create PR which supports this.

[vincentjorgensen]

That's what I feared. Time to roll up the sleeves and step out of my comfort zone. Thanks!

[vincentjorgensen]

I've dived in and I'm updating the API for projectcontour (vs heptio-contour, but I'm leaving ingressroute alone), however, I get the following error while running make:

go: finding github.com/googleapis/gax-go/v2 v2.0.5
build sigs.k8s.io/external-dns: cannot load github.com/envoyproxy/go-control-plane/pkg/util: module github.com/envoyproxy/go-control-plane@latest found (v0.9.2), but does not contain package github.com/envoyproxy/go-control-plane/pkg/util
make: *** [build/external-dns] Error 1

Golang version:

go version go1.13.4 darwin/amd64

[vincentjorgensen]

Looks like the issue is because istio.io/istio has version dependency requirements for envoyproxy/go-control-plane is different from projectcontour/contour. The former needs a version < 0.9 and the latter >= 0.9.0 due to the removal of pkg/util in releases after 0.9. Does go allow for multiple versions to be specified on a per-package basis?

[dechiad1]

Hi @vincentjorgensen - are you still running with this? My team is also very interested in this & I would love to take a shot at it, but I don't want to overstep. Thanks!

[vincentjorgensen]

TL;DR Have at it! My day job has interfered with my ability to pursue this. Last I talked with my inhouse golang expert, multi-version dependencies aren't possible in golang, so I was going to rip out the istio stuff and see if I could get a non-standard fork with minimum viability. As of right now, though, it's on hold while I finish up more urgent work responsibilities.

…

On Mon, Jan 27, 2020 at 2:43 PM Daniel DeChiara ***@***.***> wrote: Hi @vincentjorgensen <https://github.com/vincentjorgensen> - are you still running with this? My team is also very interested in this & I would love to take a shot at it, but I don't want to overstep. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1366?email_source=notifications&email_token=AAHAF6ZW2R52FHLWCD2UUQLQ75PQRA5CNFSM4KGLYK7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKBLIDA#issuecomment-578991116>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHAF64VRTNHMGECMLH6JP3Q75PQRANCNFSM4KGLYK7A> .

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[stevesloka]

I started a PR to update the deps of the current Contour integration and have run into the same issues you have @vincentjorgensen.

We are currently adding status information to HTTPProxies so we should be able to update this integration nicely.

Until then, my current goal was to update the deps so that it's not blocking this project any longer. Then when we have the status information integrated, then we'll update with HTTPProxy support in a follow-up PR.

// cc @tariq1890

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[voor]

/remove-lifecycle rotten

[josephglanville]

@stevesloka what is the status of this effort? We would like to use this and would be happy to pick up the torch if this has stalled out.

[stevesloka]

@josephglanville We now have lbstatus info in HTTPProxy object as of Contour v1.5.0, so this integration can happen now:

Status:
  Current Status:  valid
  Description:     valid HTTPProxy
  Load Balancer:
    Ingress:
      Hostname:  ac34879b5a3b1.us-east-2.elb.amazonaws.com

If you'd like to do this please go ahead. Let me know how I can help assist. =)

[josephglanville]

Yup I will pick this up and start work on it, will let you know when I have a WIP PR for review. Thanks for the swift reply. 😄

[josephglanville]

Looks like this is going to be painful because upgrading the Contour client bumps the required Kubernetes client past v1.18 which breaks Istio, Openshift and Linode. I will probably do the bumping in a separate PR and then go from there.

[seanmalloy]

/kind feature