Only dump config in debug mode

[ruudk]

Doesn't make sense to dump this in normal info level:

INFO[0000] config: {Master: KubeConfig: RequestTimeout:30s .... }

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruudk
To complete the pull request process, please assign hjacobs
You can assign the PR to them by writing /assign @hjacobs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ruudk]

/assign @hjacobs

[jgrumboe]

I find it very useful.
And since it is only once at startup it doesn't spam logs.
I would leave it at info level.

[ruudk]

This is an internal Go struct dumped into the log. It’s not human readable.

If you want this info, you can:

• use debug log level
• or describe the pod to see its arguments (config)
• or create a PR to properly show the config in human readable way

[jgrumboe]

Do you really think it's not human-readable? It's a list of key:values (json-like) which is fine in my opinion.

[ruudk]

Yes, it’s very difficult for me to read through huge blobs like that, especially since it’s not formatted with newlines and indentations.

[jgrumboe]

Ok. Got your point.
I could imagine a human readable format (newlines, indentation,...) just printing the relevant global settings (including defaults) and the ones for the configured source and provider in info-level at startup.
Leaving all nonconfigured sources, providers, etc. in the existing dump at debug level.

[Raffo]

I agree that it is useful and being printed only at startup, not a problem. I would welcome a prettier print of that config.

[Raffo]

This has been open long enough and it seems there is no interesting in adding the prettier print. Given that the current print is useful, I'm going to close this PR.