Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook manifest incorrectly limited to v1alpha2 and v1beta1 API versions #2674

Closed
robscott opened this issue Dec 12, 2023 · 5 comments
Closed
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@robscott
Copy link
Member

What happened:
As initially reported in #2673, the API resources and versions that the webhook is watching are outdated:

- operations: [ "CREATE" , "UPDATE" ]
apiGroups: [ "gateway.networking.k8s.io" ]
apiVersions: [ "v1alpha2", "v1beta1" ]
resources: [ "gateways", "gatewayclasses", "httproutes" ]

What you expected to happen:
These should be aligned directly with the versions specified in the corresponding code:

v1a2TCPRouteGVP = meta.GroupVersionResource{
Group: v1alpha2.GroupVersion.Group,
Version: v1alpha2.GroupVersion.Version,
Resource: "tcproutes",
}
v1a2UDPRouteGVP = meta.GroupVersionResource{
Group: v1alpha2.GroupVersion.Group,
Version: v1alpha2.GroupVersion.Version,
Resource: "udproutes",
}
v1a2TLSRouteGVP = meta.GroupVersionResource{
Group: v1alpha2.GroupVersion.Group,
Version: v1alpha2.GroupVersion.Version,
Resource: "tlsroutes",
}
v1a2GRPCRouteGVR = meta.GroupVersionResource{
Group: v1alpha2.SchemeGroupVersion.Group,
Version: v1alpha2.SchemeGroupVersion.Version,
Resource: "grpcroutes",
}
v1b1HTTPRouteGVR = meta.GroupVersionResource{
Group: v1beta1.SchemeGroupVersion.Group,
Version: v1beta1.SchemeGroupVersion.Version,
Resource: "httproutes",
}
v1b1GatewayGVR = meta.GroupVersionResource{
Group: v1beta1.SchemeGroupVersion.Group,
Version: v1beta1.SchemeGroupVersion.Version,
Resource: "gateways",
}
v1b1GatewayClassGVR = meta.GroupVersionResource{
Group: v1beta1.SchemeGroupVersion.Group,
Version: v1beta1.SchemeGroupVersion.Version,
Resource: "gatewayclasses",
}
v1HTTPRouteGVR = meta.GroupVersionResource{
Group: v1.SchemeGroupVersion.Group,
Version: v1.SchemeGroupVersion.Version,
Resource: "httproutes",
}
v1GatewayGVR = meta.GroupVersionResource{
Group: v1.SchemeGroupVersion.Group,
Version: v1.SchemeGroupVersion.Version,
Resource: "gateways",
}
v1GatewayClassGVR = meta.GroupVersionResource{
Group: v1.SchemeGroupVersion.Group,
Version: v1.SchemeGroupVersion.Version,
Resource: "gatewayclasses",
}

@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Dec 12, 2023
@robscott
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@robscott:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 12, 2023
@robscott robscott added this to the v1.0.1 milestone Dec 12, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Dec 22, 2023

Should we close this since #2595 ?

@sawsa307
Copy link
Contributor

sawsa307 commented Jan 3, 2024

I would like to help on this one.

/assign

@robscott
Copy link
Member Author

robscott commented Jan 8, 2024

Fixed by @2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants