Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Testing setup with Makefile #106

Closed
rjsadow opened this issue Jan 18, 2024 · 4 comments
Closed

Simplify Testing setup with Makefile #106

rjsadow opened this issue Jan 18, 2024 · 4 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@rjsadow
Copy link
Collaborator

rjsadow commented Jan 18, 2024

All of the prow end to end tests that we have use the same setup where we build the binary then run the script. Example: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/hydrophone/hydrophone-periodic.yaml#L32-L34

We could simplify this by adding a make command called test-e2e in the Makefile that runs build then invokes the hack/run-e2e.sh script.

If anyone wants to take a look at this, please feel free to assign yourself to the issue. And if there are any questions, reach out in this issue or to me on slack at @rjsadow

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@rjsadow:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

All of the prow end to end tests that we have use the same setup where we build the binary then run the script. Example: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/hydrophone/hydrophone-periodic.yaml#L32-L34

We could simplify this by adding a make command called test-e2e in the Makefile that runs build then invokes the hack/run-e2e.sh script.

If anyone wants to take a look at this, please feel free to assign yourself to the issue. And if there are any questions, reach out in this issue or to me on slack at @rjsadow

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 18, 2024
@rjsadow
Copy link
Collaborator Author

rjsadow commented Jan 18, 2024

cc @NaveenGokavarapu19 If you're interested please assign yourself!

@NaveenGokavarapu19
Copy link
Contributor

/assign

sharmaansh21 added a commit to sharmaansh21/hydrophone that referenced this issue Jan 18, 2024
NaveenGokavarapu19 added a commit to NaveenGokavarapu19/hydrophone that referenced this issue Jan 19, 2024
This was referenced Jan 19, 2024
@rjsadow
Copy link
Collaborator Author

rjsadow commented Jan 22, 2024

Fixed with #122

@rjsadow rjsadow closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants