-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce multipathd usage as it timeout if large number of disks (OCPBUGS-16878) #422
Conversation
Hi @yussufsh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
49f897a
to
31bdfa4
Compare
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind flake
/kind regression
What this PR does / why we need it:
This PR will not use multipathd commands to list paths or maps for calculating the devices used in the CSI driver. Instead dmsetup command is used which is thread-safe and does not time out in case of a large number of disks.
We can find the number of active disks in a path and use it.
Also, we do not need to handle error or faulty paths. Just removing the mpath for faulty (not active) disks we can handle orphans cleanup which ensures the new disks get detected.
Which issue(s) this PR fixes:
Fixes #261 (It is already fixed, this PR will improve on same)
Special notes for your reviewer:
Integration tests are run on device pkg. Need to do multiple e2e runs, will confirm once done.
Release note: