Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce multipathd usage as it timeout if large number of disks (OCPBUGS-16878) #422

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

yussufsh
Copy link
Contributor

What type of PR is this?

/kind flake
/kind regression

What this PR does / why we need it:

This PR will not use multipathd commands to list paths or maps for calculating the devices used in the CSI driver. Instead dmsetup command is used which is thread-safe and does not time out in case of a large number of disks.
We can find the number of active disks in a path and use it.
Also, we do not need to handle error or faulty paths. Just removing the mpath for faulty (not active) disks we can handle orphans cleanup which ensures the new disks get detected.

Which issue(s) this PR fixes:

Fixes #261 (It is already fixed, this PR will improve on same)

Special notes for your reviewer:

Integration tests are run on device pkg. Need to do multiple e2e runs, will confirm once done.

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yussufsh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2023
@mkumatag
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2023
@yussufsh yussufsh changed the title reduce multipathd usage as it timeout if large number of disks reduce multipathd usage as it timeout if large number of disks (OCPBUGS-16878) Jul 27, 2023
@yussufsh yussufsh force-pushed the test branch 3 times, most recently from 49f897a to 31bdfa4 Compare July 27, 2023 10:06
pkg/device/multipath.go Outdated Show resolved Hide resolved
pkg/device/multipath.go Outdated Show resolved Hide resolved
pkg/device/multipath.go Outdated Show resolved Hide resolved
pkg/device/multipath.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2023
@yussufsh yussufsh requested a review from mkumatag July 28, 2023 06:23
pkg/device/device.go Outdated Show resolved Hide resolved
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@mkumatag
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't use the multipath devices for mounting to the target volume
3 participants