Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CidrLimit configuration variable #93

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

stonith
Copy link
Contributor

@stonith stonith commented Dec 5, 2022

  • default to 64 if CidrLimit configuration variable doesn't exist
  • Allow setting CidrLimit limit to be set via configuration variable

supercedes #91

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2022
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stonith ! I like this approach better to allow for more flexibility.

One minor request - could you update also https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/agent-config/config to show case this new field? Thanks!

/cc @jingyuanliang

@k8s-ci-robot
Copy link
Contributor

@MrHohn: GitHub didn't allow me to request PR reviews from the following users: jingyuanliang.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks @stonith ! I like this approach better to allow for more flexibility.

One minor request - could you update also https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/agent-config/config to show case this new field? Thanks!

/cc @jingyuanliang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@stonith
Copy link
Contributor Author

stonith commented Dec 6, 2022

Thanks @stonith ! I like this approach better to allow for more flexibility.

One minor request - could you update also https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/agent-config/config to show case this new field? Thanks!

/cc @jingyuanliang

Done, also updated the README.

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, stonith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a6f1082 into kubernetes-sigs:master Dec 6, 2022
@epk epk deleted the cidr_limit_config branch December 6, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants