-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove remaining alpha fields from codebase #819
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:main
from
jonathan-innis:remove-remaining-alpha-fields
Nov 25, 2023
Merged
chore: Remove remaining alpha fields from codebase #819
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:main
from
jonathan-innis:remove-remaining-alpha-fields
Nov 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Nov 24, 2023
k8s-ci-robot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Nov 24, 2023
jonathan-innis
force-pushed
the
remove-remaining-alpha-fields
branch
4 times, most recently
from
November 24, 2023 19:17
56f632b
to
d9765ed
Compare
k8s-ci-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Nov 24, 2023
jonathan-innis
force-pushed
the
remove-remaining-alpha-fields
branch
4 times, most recently
from
November 24, 2023 20:53
b0611ed
to
aa9110c
Compare
jonathan-innis
force-pushed
the
remove-remaining-alpha-fields
branch
from
November 24, 2023 20:54
aa9110c
to
ec75cc1
Compare
Pull Request Test Coverage Report for Build 6984745902
💛 - Coveralls |
ellistarn
approved these changes
Nov 25, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ellistarn, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ellistarn Need a |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This change removes the remaining alpha field logic handling that's still present in the codebase so that Karpenter only supports the beta APIs moving forward.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.