Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove remaining alpha fields from codebase #819

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

This change removes the remaining alpha field logic handling that's still present in the codebase so that Karpenter only supports the beta APIs moving forward.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 24, 2023
@jonathan-innis jonathan-innis force-pushed the remove-remaining-alpha-fields branch 4 times, most recently from 56f632b to d9765ed Compare November 24, 2023 19:17
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 24, 2023
@jonathan-innis jonathan-innis force-pushed the remove-remaining-alpha-fields branch 4 times, most recently from b0611ed to aa9110c Compare November 24, 2023 20:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6984745902

  • 39 of 41 (95.12%) changed or added relevant lines in 16 files are covered.
  • 98 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.6%) to 79.541%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/provisioning/provisioner.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/provisioner.go 1 79.26%
pkg/controllers/state/statenode.go 1 86.09%
pkg/apis/v1alpha5/provisioner_validation.go 2 91.47%
pkg/controllers/disruption/drift.go 2 79.1%
pkg/controllers/nodeclaim/lifecycle/initialization.go 2 90.54%
pkg/utils/nodepool/nodepool.go 2 82.14%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
pkg/apis/v1alpha5/register.go 10 0.0%
pkg/apis/v1alpha5/zz_generated.deepcopy.go 71 0.0%
Totals Coverage Status
Change from base Build 6963402001: -0.6%
Covered Lines: 8114
Relevant Lines: 10201

💛 - Coveralls

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ellistarn, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ellistarn,jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonathan-innis
Copy link
Member Author

@ellistarn Need a /lgtm for approval now

@ellistarn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0a0b0de into kubernetes-sigs:main Nov 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants