feat: allow node annotations to be set by the provisioner #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellistarn
force-pushed
the
annotations
branch
3 times, most recently
from
7153e8d
to
b21701b
Compare
ellistarn
force-pushed
the
annotations
branch
from
b21701b
to
6150a5c
Compare
Pull Request Test Coverage Report for Build 3550610940
💛 - Coveralls |
This was referenced Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
This feature lets you set
karpenter.sh/do-not-consolidateon any node launched by the provisioner. We could implement similar mechanisms forkarpenter.sh/do-not-upgradekarpenter.sh/do-not-rebalanceetc. Essentially, instead of strongly typing all future concepts onto the provisioner, we maintain a flexible set of annotations (similar to scheduling requirement labels) at the node level that can be applied by Provisioners. It's also flexible and neutral to vendor specific annotations.How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.