-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRI installation instructions page #10299
Add CRI installation instructions page #10299
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 5befdc6 https://deploy-preview-10299--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 61c1f4a https://deploy-preview-10299--kubernetes-io-master-staging.netlify.com |
5befdc6
to
d56ed16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stable" | ||
|
||
# Install docker. | ||
apt-get update && apt-get install docker-ce=17.03.2~ce-0~ubuntu-xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are merging a PR to validate 18.06 by default:
kubernetes/kubernetes#68495
[1]
https://download.docker.com/linux/centos/docker-ce.repo | ||
|
||
# Install docker. | ||
apt-get update && yum install docker-ce-17.03.2.ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[1]
/assign @Bradamant3 @timothysc |
@bart0sh @neolit123 the original PR is now closed. This looks good now. |
Thanks for pointing this out. Will rebase this or create new PR. Note, this is work in progress. Things I'm considering to do:
|
@bart0sh Docs PRs must be merged by 9/18. Please rebase and finish up any WIP items by then. Thanks! |
content/en/docs/setup/cri/_index.md
Outdated
--- | ||
title: Kubernetes CRI | ||
weight: 30 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are more topics planned for CRI? If not, we should have a single "CRI Installation" topic instead of nesting only one topic.
|
||
{{< tabs name="tab-cri-docker-installation" >}} | ||
{{< tab name="Ubuntu 16.04" codelang="bash" >}} | ||
# Install prerequisites. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fixed up this line to display properly)
61c1f4a
to
67853ae
Compare
Deploy preview for kubernetes-io-vnext-staging processing. Built with commit 67853ae https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b9f799b67610c3596a4fe62 |
Deploy preview for kubernetes-io-vnext-staging processing. Built with commit eea1385 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5ba21771b13fb15bba25ca20 |
67853ae
to
04713e7
Compare
fa84aaa
to
f55a6d7
Compare
content/en/docs/setup/cri.md
Outdated
{{< /tab >}} | ||
{{< tab name="CentOS/RHEL 7.4+" codelang="bash" >}} | ||
|
||
#### Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same sysctl set needed by containerd is needed by CRI-O.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. Should be fixed now.
d0f07cd
to
b1e1d2e
Compare
I think I'm done with this. Please review and approve. |
thanks @bart0sh |
@neolit123 Thank you! BTW, should I send this to master as well? |
no, there is no need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
b1e1d2e
to
71c0cfb
Compare
00f0e47
to
4da32a8
Compare
Added cri-installation page with CRI installation instructions Referenced it from kubeadm-init and install-kubeadm pages.
4da32a8
to
eea1385
Compare
As this PR is not merged yet I did a bit of markup changes to make the page looking a bit better. |
@bart0sh /lgtm |
@kubernetes/sig-docs-pr-reviews - We are good to go, merge request, please. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryanmcginnis, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Added cri-installation page with CRI installation instructions
Referenced it from kubeadm-init and install-kubeadm pages.
Which issue this PR fixes
Fixes: kubernetes/kubeadm#1086, #9692
Release note: