Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Ginkgo focus is not working on ./hack/test_e2e.sh script #477

Closed
knabben opened this issue Apr 5, 2023 · 6 comments
Closed

Ginkgo focus is not working on ./hack/test_e2e.sh script #477

knabben opened this issue Apr 5, 2023 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@knabben
Copy link
Contributor

knabben commented Apr 5, 2023

Passing it as an env var is not read by the shell script, and the hardcoded one is always used: GINKGO_FOCUS='\[Conformance\]|\[sig-network\]'

For example:

 GINKGO_FOCUS="should resolve DNS of partial qualified names for services" bash -x ./hack/test_e2e.sh -i ipv4 -b iptables

GINKGO_FOCUS must read from an environment variable instead of using the hardcoded value.

@knabben
Copy link
Contributor Author

knabben commented Apr 5, 2023

/help

@k8s-ci-robot
Copy link
Contributor

@knabben:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 5, 2023
@knabben
Copy link
Contributor Author

knabben commented Apr 5, 2023

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@knabben:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 5, 2023
@abhaikollara
Copy link
Contributor

/assign

@knabben
Copy link
Contributor Author

knabben commented Apr 6, 2023

Next PR please add Fixes #PRNUMBER in the description and it will close this issue automatically

@knabben knabben closed this as completed Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants