Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Adds gofmt verification #485

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Adds gofmt verification #485

merged 3 commits into from
Apr 19, 2023

Conversation

gitvinit
Copy link
Contributor

Adds gofmt verification for pull requests and pushes to master branch

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 11, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gitvinit / name: Vinit Badrike (85f7c58)

@k8s-ci-robot
Copy link
Contributor

Welcome @gitvinit!

It looks like this is your first PR to kubernetes-sigs/kpng 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kpng has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2023
aroradaman
aroradaman reviewed Apr 12, 2023
View reviewed changes
hack/update-gofmt.sh Outdated
@@ -0,0 +1,40 @@
#!/usr/bin/env bash

# Copyright 2014 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the year to 2023, not sure though.
thoughts @jayunit100 @knabben ?

Rest all looks good and matches k/k upstream!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On new file use the year this is being created. If you are changing an existent file - keep the old date, or change for 2014-2023.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review Amim and Daman updated the date

knabben
knabben reviewed Apr 12, 2023
View reviewed changes
hack/verify-gofmt.sh Outdated
@@ -0,0 +1,57 @@
#!/usr/bin/env bash

# Copyright 2021 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the date here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the date as per comment

knabben
knabben reviewed Apr 12, 2023
View reviewed changes
hack/verify-gofmt.sh Outdated Show resolved Hide resolved
knabben
knabben reviewed Apr 12, 2023
View reviewed changes
hack/verify-gofmt.sh
# limitations under the License.

# This script checks whether the source code needs to be formatted or not by
# `gofmt`. Run `hack/update-gofmt.sh` to actually format sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about bring some notes in the README, and clarify the difference between both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure Amim added to README

knabben
knabben reviewed Apr 18, 2023
View reviewed changes
hack/README.md
@@ -149,7 +149,8 @@ pushing directly to a local registry and configuring kind to use this reg, so do
isnt required.
- Or a `tilt` recipe which hot reloads all kpng on code changes.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the future, these kind of linters are better integrated in the IDE, we can update the readme on a next moment with the instructions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sounds good

@knabben
Copy link
Contributor

knabben commented Apr 19, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitvinit, knabben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 48b7bca into kubernetes-retired:master Apr 19, 2023
@gitvinit gitvinit mentioned this pull request May 23, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@knabben knabben knabben left review comments

@aroradaman aroradaman aroradaman left review comments

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

Assignees

@knabben knabben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gitvinit @k8s-ci-robot @knabben @aroradaman