Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

programming only Local Endpoint in KUBE-LOOP_BACK #79

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

hanamantagoudvk
Copy link
Contributor

@hanamantagoudvk hanamantagoudvk commented Oct 18, 2021

This PR contains following code changes:

a) "local" flag present in EndPoint struct is being populated correctly based on NodeName field.
This flag is important in ipvs backend to decide whether to add or not , the endpoint details into KUBE-LOOP_BACK ipset.
Hence the changes are made in kpng controller before storing the endpoint into the tree. Same flag can be used by other backends as well to know whether the endpoint is local or remote for that node.

b) Older IPVS backend is removed as its not required anymore.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 18, 2021
@jayunit100 jayunit100 mentioned this pull request Oct 22, 2021
@mcluseau
Copy link
Contributor

hi, there a no informations about local things in the global model. The locality information is provided when the global model is converted to the local one. See https://github.com/kubernetes-sigs/kpng/blob/master/client/localsink/localsink.go#L29 for the struct to put in the backend: it gives a func BindFlags to be used by the built command (see https://github.com/kubernetes-sigs/kpng/blob/master/cmd/kpng/storecmds/storecmds.go#L122).

Note that this is something that will be refactored to the registration mecanism we want to build for dynamic commands depending on the environment (linux/windows) and to allow easy custom binaries.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@hanamantagoudvk hanamantagoudvk changed the title Determining Local Endpoint programming only Local Endpoint in KUBE-LOOP_BACK Nov 3, 2021
@mcluseau
Copy link
Contributor

mcluseau commented Nov 5, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanamantagoudvk, mcluseau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit a761691 into kubernetes-retired:master Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants