Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature add frontend ci #58

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Feature add frontend ci #58

merged 5 commits into from
Dec 20, 2021

Conversation

sivchari
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

I added lint check of frontend on GitHub Actions.

Which issue(s) this PR fixes:

Related #5

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 16, 2021
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2021
@sivchari
Copy link
Member Author

/assign @sanposhiho

@sanposhiho
Copy link
Member

This should be after #7. I'll be back after that.

sanposhiho
sanposhiho reviewed Dec 17, 2021
View reviewed changes
web/package.json Outdated
@@ -10,7 +10,7 @@
"format": "prettier --write .",
"lint:js": "eslint --ext \".js,.vue\" --ignore-path .gitignore .",
"lint:css": "stylelint \"**/**.{css,scss,sass}\"",
"lint": "yarn lint:js lint:css",
"lint": "yarn run lint:js && yarn run lint:css",
Copy link
Member

@sanposhiho sanposhiho Dec 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please delete the changes on package.json from this PR? This issue will be solved in #7 as well.

@sivchari
Copy link
Member Author

@sanposhiho

Thanks for comment.
I confirmed #7 is merged. So, I fixed and pushed.

sanposhiho
sanposhiho reviewed Dec 19, 2021
View reviewed changes
.github/workflows/lint-frontend.yml Outdated
run: npm install -g yarn
- name: Install
run: yarn install --frozen-lockfile
- name: Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Test
- name: Lint

.github/workflows/lint-frontend.yml Outdated
- name: Setup Node.js v16
uses: actions/setup-node@v2
with:
node-version: 16.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work? I cannot find the syntax 16.X on the official readme of setup-node action.
https://github.com/marketplace/actions/setup-node-js-environment

Suggested change
node-version: 16.x
node-version: '16'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works.
setup-node downloads from https://nodejs.org/dist . And v16.x is released from that.
If you are worry, I change 16.x to 16.

FYI

https://github.com/actions/setup-node/blob/04c56d2f954f1e4c69436aa54cfef261a018f458/src/installer.ts#L266-L298

https://nodejs.org/dist/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. But, yeah, please change it. Just to be safe in the future, let's go the way that the official suggests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

sanposhiho
sanposhiho approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, sivchari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9d7b573 into kubernetes-sigs:master Dec 20, 2021
This was referenced Dec 20, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@adtac adtac Awaiting requested review from adtac

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sivchari @sanposhiho @k8s-ci-robot