Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: file name .dockerignore has blank #9

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

sanposhiho
Copy link
Member

Hello team.
.dockerignore has blank on its filename and git cannot checkout successfully on windows.

Thanks for reporting, @warmchang.

#8 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2021
@sanposhiho
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2021
@adtac
Copy link

adtac commented Aug 31, 2021

The file is still empty? Did you mean to add a newline? I don't see it in the diff

@sanposhiho
Copy link
Member Author

@adtac
It looks like there is no change, but actually the file name has been changed :)

.dockerignore (two whitespaces after name) → .dockerignore (delete two whitespaces)

(You can tell from the URL that it contains two whitespaces (%20%20).)
https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/.dockerignore%20%20

@sanposhiho sanposhiho mentioned this pull request Sep 12, 2021
6 tasks
@sanposhiho
Copy link
Member Author

@adtac ping

@sanposhiho
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 30, 2021
@Huang-Wei
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@Huang-Wei
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Huang-Wei,sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit bcfc74b into kubernetes-sigs:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants