Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mockkubeapiserver: register built-in types #278

Merged
merged 1 commit into from
Dec 5, 2022
Merged

mockkubeapiserver: register built-in types #278

merged 1 commit into from
Dec 5, 2022

Conversation

justinsb
Copy link
Contributor

We generate a metadata file that includes the additional type
information we need.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2022
@justinsb
Copy link
Contributor Author

/assign @apelisse

@justinsb
mockkubeapiserver: register built-in types
a1c029c 
We generate a metadata file that includes the additional type
information we need.
apelisse
apelisse reviewed Nov 28, 2022
View reviewed changes
mockkubeapiserver/kubernetes_builtin_schema.go
}

schemaYAML := kubernetesBuiltinSchemaYAML
if key != BuiltinKey {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it, if the key is NOT "BuiltInKey", then this will fail, but then how do you get anything but "BuiltinKey" in the list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only one that works at the moment. But I thought this was clearer (externally) and can allow for more in future... It's not great, but maybe it's better than the multiple globals we had before.

@apelisse
Copy link
Contributor

apelisse commented Dec 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 173ddfe into kubernetes-sigs:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse apelisse left review comments

@atoato88 atoato88 Awaiting requested review from atoato88

@johnsonj johnsonj Awaiting requested review from johnsonj

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @apelisse