-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable lint golint and fix notifications #1291
Conversation
/assign @droot |
/assign @mengqiy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is doing several changes that were being tracked under #1176:
1- Remove Prometheus
prefix inside the prometheus
package: tracking issue: #1181
2- Error string formatting: tracking issue #1177, implemented in #1184 but missed that .
3- Unification of receiver names: tracking issue #1182, pending PR #1186.
4- else
blocks after if
blocks that end with a return
.
Additionally you are introducing some golint:nolint markers which I really would try to avoid.
This comment has been minimized.
This comment has been minimized.
Please rebase. |
e0d535f
to
f49d87d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ ./scripts/verify.sh
running go vet
running go fmt
running golangci-lint
pkg/scaffold/scaffold.go:103:1: receiver name should not be an underscore, omit the name if it is unused (golint)
func (_ *Scaffold) validate(file input.File) error {
^
The command "./scripts/verify.sh" exited with 1.
I guess you need to change line 103 to:
func (*Scaffold) validate(file input.File) error {
Otherwise LGTM.
LGTM Please add "Closes #1181" to the top so that the issue gets closed when this PR gets merged. |
Please squash your commits please |
e3c9c7e
to
c55c49c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This one needs rebase |
@mengqiy done the rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
Closes: #1181