Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubelet topology manager policy on the node #10370

Merged

Conversation

0ekk
Copy link
Contributor

@0ekk 0ekk commented Aug 17, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
In high latency-critical execution and high-throughput parallel computation, to obtain the best performance, optimizations related to CPU isolation, memory and device locality are required.
Topology manager can make decisions for that by leveraging NUMA technology.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add kubelet topology manager policy on the node (`kubelet_topology_manager_scope` and `kubelet_topoloy_manager_policy`)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2023
@0ekk 0ekk force-pushed the add_topology_manager_policy branch from e7f44ca to defb9f4 Compare August 17, 2023 07:46
Signed-off-by: tu1h <lihai.tu@daocloud.io>
@0ekk 0ekk force-pushed the add_topology_manager_policy branch from defb9f4 to 1c0d38f Compare August 17, 2023 07:48
@yankay
Copy link
Member

yankay commented Aug 18, 2023

Thanks @tu1h

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tu1h Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, tu1h

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit cafe4f1 into kubernetes-sigs:master Aug 18, 2023
59 checks passed
@yankay yankay mentioned this pull request Aug 24, 2023
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants