-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup recover control plane playbook + add debian12/cilium test #10411
Fixup recover control plane playbook + add debian12/cilium test #10411
Conversation
d1fa431
to
c801aa9
Compare
c801aa9
to
a4bc3ee
Compare
CI jobs now green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @floryut
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 🙏
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rnetes-sigs#10411) * Add debian12 cilium testing * Fixup recover control plane playbook
…rnetes-sigs#10411) * Add debian12 cilium testing * Fixup recover control plane playbook
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixing https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5005826473 and https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5005826332 which are failing with
"The conditional check 'not has_quorum' failed.
errorAlso fixing warning
[WARNING]: Could not match supplied host pattern, ignoring: kube_control_plane:!fake_hosts
as ansible don't like mixing "," and ":".Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Commit which broke this playbook: 25cb90b
Last but not least, I need a new debian12 test to validate debian12 with cilium 😛
Does this PR introduce a user-facing change?: