Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop installation notes for Debian Jessie #10642

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jelmer
Copy link
Contributor

@jelmer jelmer commented Nov 23, 2023

Drop installation notes for Debian Jessie

Jessie has not received security updates for at least three years. See https://www.debian.org/releases/jessie/

Does this PR introduce a user-facing change?:

Drop installation notes for Debian Jessie

Jessie has not received security updates for at least three years. See https://www.debian.org/releases/jessie/
Copy link

linux-foundation-easycla bot commented Nov 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jelmer / name: Jelmer Vernooij (b612409)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 23, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jelmer!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jelmer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 23, 2023
@yankay
Copy link
Member

yankay commented Nov 24, 2023

Thanks @jelmer

It's welcome to provide the PR.
Debian Jessie is deprecated, but the kubespray still supports Debian.
So it seems better to update the docs to a new version than remove it.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2023
@jelmer
Copy link
Contributor Author

jelmer commented Nov 24, 2023

Thanks @jelmer

It's welcome to provide the PR. Debian Jessie is deprecated, but the kubespray still supports Debian. So it seems better to update the docs to a new version than remove it.

/ok-to-test

From my experience and based on the instructions here, newer versions of Debian don't need any specific workarounds. I could drop the jessie-specific instructions but leave this page empty if you prefer?

@yankay
Copy link
Member

yankay commented Nov 24, 2023

Thanks @jelmer

Hi @jelmer
After some invesgating, I have checked there needs not any specific workarounds .
/lgtm
Thanks :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelmer Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, jelmer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit fa7a504 into kubernetes-sigs:master Nov 28, 2023
63 checks passed
@yankay yankay mentioned this pull request Dec 15, 2023
@floryut floryut added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 21, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Jessie has not received security updates for at least three years. See https://www.debian.org/releases/jessie/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants