Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for crio #10785

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

qlijin
Copy link
Member

@qlijin qlijin commented Jan 10, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Update docs for crio. Add introductions for the following variables:

crio_insecure_registries
crio_registry_auth

And test the installation successfully.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2024
@ErikJiang
Copy link
Member

Please clean up extra spaces in the document.

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5899657444#L23

@qlijin
Copy link
Member Author

qlijin commented Jan 12, 2024

ok. Thank you for pointing out that.

@VannTen
Copy link
Contributor

VannTen commented Jan 12, 2024

You'll need to rebase on latest master to pick the CI vagrant fix

@qlijin
Copy link
Member Author

qlijin commented Jan 15, 2024

ok, I'll rebase on latest master.

@VannTen
Copy link
Contributor

VannTen commented Jan 15, 2024

/lgtm
(Should re-trigger the failing test I think)
/assign @yankay @mzaian
(approval)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@VannTen
Copy link
Contributor

VannTen commented Jan 15, 2024

/retest pull-kubespray-yamllint

@k8s-ci-robot
Copy link
Contributor

@VannTen: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-kubespray-yamllint

Use /test all to run all jobs.

In response to this:

/retest pull-kubespray-yamllint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VannTen
Copy link
Contributor

VannTen commented Jan 15, 2024

/test pull-kubespray-yamllint

@yankay
Copy link
Member

yankay commented Jan 16, 2024

Thanks @qlijin
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qlijin, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit beb2660 into kubernetes-sigs:master Jan 16, 2024
65 checks passed
@yankay yankay mentioned this pull request Jan 19, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants