Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change debian12 network manage service from networking to systemd-netw… #11058

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

KubeKyrie
Copy link
Contributor

@KubeKyrie KubeKyrie commented Apr 5, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #11050

Special notes for your reviewer:
Debian 12 has changed network manage service from networking to systemd-networkd

Does this PR introduce a user-facing change?:

fix network manage service of Debian 12

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2024
@VannTen
Copy link
Contributor

VannTen commented Apr 5, 2024 via email

@KubeKyrie
Copy link
Contributor Author

Oh, title mistaken! Thanks for reminding me!

@KubeKyrie KubeKyrie changed the title change debian8 network manage service from networking to systemd-netw… change debian12 network manage service from networking to systemd-netw… Apr 5, 2024
@yankay
Copy link
Member

yankay commented Apr 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2024
…orkd

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
@KubeKyrie
Copy link
Contributor Author

@mzaian @VannTen PTAL, thanks.

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @KubeKyrie

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KubeKyrie, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit e87040d into kubernetes-sigs:master Apr 9, 2024
60 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
…orkd (kubernetes-sigs#11058)

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…orkd (kubernetes-sigs#11058)

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
…orkd (kubernetes-sigs#11058)

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
…orkd (kubernetes-sigs#11058)

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect reset_restart_network_service_name in reset playbook for debian 12
5 participants