fix : kubespray v2.24.1 cannot bootstrap in Oracle Linux 7

[aryasoni98]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR addresses the issue of duplicate dictionary keys in various YAML files, which can lead to unexpected behavior in Ansible and other tools. It ensures that keys are unique and properly formatted, enhancing the reliability of the codebase.

Which issue(s) this PR fixes:

Fixes #11129

Special notes for your reviewer:

This PR includes changes to:

• roles/bootstrap-os/tasks/main.yml
• contrib/dind/group_vars/all/distro.yaml

Does this PR introduce a user-facing change?:

Fixed duplicate dictionary key issue in YAML files to prevent unexpected behavior.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aryasoni98
Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @aryasoni98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[VannTen]

Thanks for working on a pull request.
Unfortunately, this is not going to fix the mentioned issue and there is several problems with your patch.

YAML anchors and override are well defined. The warning from Ansible even tells you that's it's going to use the last defined value (as it should).

Secondly, you should not bundle unrelated changes with a fix, it should be as minimal as possible.
Whitespace changes in unrelated files are particularly unwelcome (whitespaces "fixes" in general are rarely a good idea, because it obscures the git history).

With that in mind, I'm going to close this.

If you still wish to fix the Oracle issue, I suggest you take some time to investigate in more details on the issue itself, before coming up with a fix (and an explanation of what the problem is, and how your problem fix it).

Thanks again !

/close

[k8s-ci-robot]

@VannTen: Closed this PR.

In response to this:

Thanks for working on a pull request.
Unfortunately, this is not going to fix the mentioned issue and there is several problems with your patch.

YAML anchors and override are well defined. The warning from Ansible even tells you that's it's going to use the last defined value (as it should).

Secondly, you should not bundle unrelated changes with a fix, it should be as minimal as possible.
Whitespace changes in unrelated files are particularly unwelcome (whitespaces "fixes" in general are rarely a good idea, because it obscures the git history).

With that in mind, I'm going to close this.

If you still wish to fix the Oracle issue, I suggest you take some time to investigate in more details on the issue itself, before coming up with a fix (and an explanation of what the problem is, and how your problem fix it).

Thanks again !

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.