Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offline note for kube-* images #8718

Merged
merged 1 commit into from
May 10, 2022

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Apr 14, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We had a question1 why kube-* images need to be handled separately when getting container image list for offline deployment.
This adds the note to explain it for long-term maintenance.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Apr 14, 2022

/cc @tmurakam @muzi502

@k8s-ci-robot
Copy link
Contributor

@oomichi: GitHub didn't allow me to request PR reviews from the following users: tmurakam, muzi502.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tmurakam @muzi502

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oomichi
Copy link
Contributor Author

oomichi commented Apr 14, 2022

To see comments from the script authors.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2022
@cristicalin
Copy link
Contributor

@oomichi considering we may not get an answer on this we might as well merge it.

@oomichi
Copy link
Contributor Author

oomichi commented May 9, 2022

@oomichi considering we may not get an answer on this we might as well merge it.

OK, this comment might be fine.
Let me drop hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2022
@tmurakam
Copy link
Contributor

Sorry for late reply, looks good to me.

@cristicalin
Copy link
Contributor

@oomichi 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit aef2581 into kubernetes-sigs:master May 10, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants