-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offline note for kube-* images #8718
Add offline note for kube-* images #8718
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@oomichi: GitHub didn't allow me to request PR reviews from the following users: tmurakam, muzi502. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To see comments from the script authors. /hold |
@oomichi considering we may not get an answer on this we might as well merge it. |
OK, this comment might be fine. /hold cancel |
Sorry for late reply, looks good to me. |
@oomichi 👍 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We had a question1 why kube-* images need to be handled separately when getting container image list for offline deployment.
This adds the note to explain it for long-term maintenance.
Does this PR introduce a user-facing change?: