Replace nodelocaldns label

[stelucz]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Replace label k8s-app: nodelocaldns in DaemonSet template by k8s-app: node-local-dns. Label in template should match upstream DaemonSet definition as other projects/deployments can rely on it.

Which issue(s) this PR fixes:

Fixes #9717

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Replace nodelocaldns label to `k8s-app: node-local-dns`

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: stelucz (bffb59a)

[k8s-ci-robot]

Welcome @stelucz!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @stelucz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stelucz]

/easycla

[liupeng0518]

/lgtm
/ok-to-test

[floryut]

@stelucz Thank you for the PR 🚀

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, stelucz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[floryut]

Could you please check CLA though ?

[stelucz]

Could you please check CLA though ?

I signed that when PR was submited.

[stelucz]

/easycla

[floryut]

Did you sign it using your commit email ? (l*.s*@eset.com)

[stelucz]

Did you sign it using your commit email ? (l*.s*@eset.com)

Thanks for pointing it out. Can I change commit email somehow?

[floryut]

Did you sign it using your commit email ? (l*.s*@eset.com)

Thanks for pointing it out. Can I change commit email somehow?

You can always amend your commit : git commit --amend --author="John Doe <john@doe.org>" then push force your branch and voilà 👍

[stelucz]

Did you sign it using your commit email ? (l*.s*@eset.com)

Thanks for pointing it out. Can I change commit email somehow?

You can always amend your commit : git commit --amend --author="John Doe <john@doe.org>" then push force your branch and voilà 👍

thanks a lot!

[oomichi]

Thanks for submitting this @stelucz

/lgtm