Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet csr approver #9877

Merged
merged 4 commits into from
May 11, 2023
Merged

Kubelet csr approver #9877

merged 4 commits into from
May 11, 2023

Conversation

j4m3s-s
Copy link
Contributor

@j4m3s-s j4m3s-s commented Mar 10, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

Adds support for Kubelet-CSR-approver to automatically approve Node CSRs when activating kubelet_rotate_server_certificates.
This fixes the security issue with kubelet self signed certificate and API server not verifying them.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds support for Kubelet-CSR-approver to auto-approve kubelet CSR when `kubelet_rotate_server_certificates`.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @j4m3s-s. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2023
@j4m3s-s j4m3s-s force-pushed the kubelet-csr-approver branch 9 times, most recently from 5b96544 to bcc073e Compare March 13, 2023 17:33
@yankay
Copy link
Member

yankay commented Mar 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2023
@j4m3s-s j4m3s-s force-pushed the kubelet-csr-approver branch 2 times, most recently from 83b80b7 to 0bf28df Compare March 17, 2023 14:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2023
@MrFreezeex MrFreezeex force-pushed the kubelet-csr-approver branch 5 times, most recently from a74e08d to 64bd2fe Compare March 23, 2023 14:42
@MrFreezeex
Copy link
Member

Here is the added job ran (same code just an extra wip commit to be able to schedule the job): https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/3989435147

@MrFreezeex MrFreezeex force-pushed the kubelet-csr-approver branch 3 times, most recently from 925f682 to 3a05b2c Compare March 29, 2023 08:51
@MrFreezeex
Copy link
Member

MrFreezeex commented Mar 29, 2023 •
edited
Loading

Should be ready, I helped @j4m3s-s / co-authored this so I am not adding my lgtm label though.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2023
j4m3s-s and others added 4 commits May 2, 2023 17:13
@j4m3s-s
chore(helm-apps): fix README example
f79874d 
README shows a non-working example according to the specs for this role.
@j4m3s-s @MrFreezeex
Add support for kubelet-csr-approver
a851552 
Co-Authored-By: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@j4m3s-s @MrFreezeex
Add tests for kubelet-csr-approver
5fb084e 
Co-Authored-By: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@j4m3s-s @MrFreezeex
Add Documentation for Kubelet CSR Approver
7cf32a1 
Co-Authored-By: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@gbolo
Copy link
Contributor

gbolo commented May 3, 2023

@j4m3s-s nice PR. This will greatly improve the security posture of the cluster when enabling cert rotation on the kublets! Thanks

floryut
floryut approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j4m3s-s Thank you for the PR 👍
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, j4m3s-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@oomichi
Copy link
Contributor

oomichi commented May 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 07d45e6 into kubernetes-sigs:master May 11, 2023
@yankay yankay mentioned this pull request May 15, 2023
Closed
@yankay yankay mentioned this pull request Feb 6, 2024
Merged
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@j4m3s-s @MrFreezeex @pedromcpedro
Kubelet csr approver (kubernetes-sigs#9877)
64b27d9 
* chore(helm-apps): fix README example

README shows a non-working example according to the specs for this role.

* Add support for kubelet-csr-approver

Co-Authored-By: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* Add tests for kubelet-csr-approver

Co-Authored-By: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* Add Documentation for Kubelet CSR Approver

Co-Authored-By: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

---------

Co-authored-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@yankay yankay Awaiting requested review from yankay

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@j4m3s-s @k8s-ci-robot @yankay @MrFreezeex @gbolo @oomichi @floryut