-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the probe option of cilium_kube_proxy_replacement #9929
Delete the probe option of cilium_kube_proxy_replacement #9929
Conversation
Hi @XiuguangHuang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XiuguangHuang Thank you for the PR
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :D
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, XiuguangHuang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In the cilium v1.13, the option
probe
ofkube-proxy-replacement
has been removed, so when creating clusters with cilium, the cilium pod can not run.https://docs.cilium.io/en/stable/operations/upgrade/#removed-options
Which issue(s) this PR fixes:
Fixes kubean-io/kubean#604
Special notes for your reviewer:
I set
cilium_kube_proxy_replacement
topartial
orstrict
, both can work.Does this PR introduce a user-facing change?:
This would cause a change to the repository's structure, meaning downstream users would either need to change their code to point to the
playbooks
directory or use theansible.builtin.import_playbook
module