Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the probe option of cilium_kube_proxy_replacement #9929

Merged

Conversation

XiuguangHuang
Copy link
Contributor

@XiuguangHuang XiuguangHuang commented Mar 27, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:
In the cilium v1.13, the option probe of kube-proxy-replacement has been removed, so when creating clusters with cilium, the cilium pod can not run.
https://docs.cilium.io/en/stable/operations/upgrade/#removed-options

Which issue(s) this PR fixes:

Fixes kubean-io/kubean#604

Special notes for your reviewer:
I set cilium_kube_proxy_replacement to partial or strict, both can work.

I0326 17:23:22.771672 3571066 service.go:38] ... podStatus is: Running
I0326 17:24:22.784877 3571066 service.go:38] ... podStatus is: Running
I0326 17:25:22.812402 3571066 service.go:38] ... podStatus is: Running
I0326 17:26:22.826294 3571066 service.go:38] ... podStatus is: Running
I0326 17:27:22.868775 3571066 service.go:38] ... podStatus is: Running
I0326 17:28:22.885784 3571066 service.go:38] ... podStatus is: Succeeded
Name: cluster1-kubeconf NameSpace: kubean-system
I0326 17:28:22.898857 3571066 service.go:67] ****get cluster success
I0326 17:28:22.916177 3571066 service.go:78] ---- Waiting Pods in %s to be Running ---kube-system
I0326 17:28:23.025626 3571066 service.go:87] Waiting cilium-bfhcdto be Running...
I0326 17:28:23.042074 3571066 service.go:87] Waiting cilium-bwtggto be Running...
I0326 17:28:23.065051 3571066 service.go:87] Waiting cilium-operator-64d9fbb8f5-bd5dxto be Running...
I0326 17:28:23.079821 3571066 service.go:87] Waiting cilium-operator-64d9fbb8f5-tw8vbto be Running...
I0326 17:28:23.092883 3571066 service.go:87] Waiting coredns-7759f8769f-cf4c4to be Running...
I0326 17:28:23.104870 3571066 service.go:87] Waiting coredns-7759f8769f-n2r86to be Running...
I0326 17:28:23.121759 3571066 service.go:87] Waiting dns-autoscaler-59449f7494-prqrrto be Running...
I0326 17:28:23.131207 3571066 service.go:87] Waiting etcd-node1to be Running...
I0326 17:28:23.140231 3571066 service.go:87] Waiting kube-apiserver-node1to be Running...
I0326 17:28:23.150694 3571066 service.go:87] Waiting kube-controller-manager-node1to be Running...
I0326 17:28:23.167577 3571066 service.go:87] Waiting kube-proxy-7zpj9to be Running...
I0326 17:28:23.332763 3571066 service.go:87] Waiting kube-proxy-kz979to be Running...
I0326 17:28:23.535907 3571066 service.go:87] Waiting kube-scheduler-node1to be Running...
I0326 17:28:23.731405 3571066 service.go:87] Waiting metrics-server-575c65464c-vkt6dto be Running...
I0326 17:28:23.933004 3571066 service.go:87] Waiting nginx-proxy-node2to be Running...
I0326 17:28:24.130525 3571066 create_cilium_cluster_test.go:60] On line, sonobuoy check

Does this PR introduce a user-facing change?:

This would cause a change to the repository's structure, meaning downstream users would either need to change their code to point to the playbooks directory or use the ansible.builtin.import_playbook module

[Cilium] Delete the probe option of cilium_kube_proxy_replacement 

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @XiuguangHuang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiuguangHuang Thank you for the PR
/ok-to-test

@floryut floryut added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, XiuguangHuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4020a93 into kubernetes-sigs:master Mar 27, 2023
@floryut floryut added kind/network Network section in the release note and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 28, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to create cilium clusters, the value 'probe' of kube-proxy-replacement is invalid.
4 participants