Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the kube-bench 1.2.20 to enhance security #9939

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

yankay
Copy link
Member

@yankay yankay commented Mar 29, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Fix kube-bench check Fail 1.2.20 by increase the default value of audit_log_maxbackups
Ref to https://github.com/aquasecurity/kube-bench/blob/main/cfg/cis-1.24/master.yaml#L627

Which issue(s) this PR fixes:

Fixes #9933

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix kube-bench  1.2.20 to enhance security (Ensure that the --audit-log-maxbackup argument is set to 10)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2023
@MrFreezeex
Copy link
Member

Thanks @yankay :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit e8f0fb8 into kubernetes-sigs:master Mar 29, 2023
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 29, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-bench some checks FAIL
4 participants