-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change nerdctl snapshotter to overlayfs by default #9979
Conversation
Hi @dmitrytretyakov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitrytretyakov Thank you for the PR 👍
I had a PR with that a while ago but closed it 😅
It was first reported here containerd/containerd#7054 so all good for me
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :D
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmitrytretyakov, floryut, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) (cherry picked from commit cdc2552)
What type of PR is this?
/kind feature
What this PR does / why we need it:
It changed nerdctl snapshotter from extremely disk space intensive "native" to containerd default "overlayfs".
You can read a very good article about snapshotters here.
In short, your 1GB image with 30 layers (like one of mine) can take 30GB disk space with native snapshotter instead of 1GB with overlayfs
Does this PR introduce a user-facing change?: