Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix calico v3.25.1 checksums mismatch #9990

Merged

Conversation

pli01
Copy link
Contributor

@pli01 pli01 commented Apr 15, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR fix an error of the calico checksum archive

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This Fix is detected in this build:

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/4119243029#L3913

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 15, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pli01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2023
@ccureau
Copy link

ccureau commented Apr 15, 2023

Thank you! This bit me today and was just about to put in the PR.

@pli01
Copy link
Contributor Author

pli01 commented Apr 15, 2023

/test pull-kubespray-yamllint

@k8s-ci-robot
Copy link
Contributor

@pli01: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubespray-yamllint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@batazor
Copy link
Contributor

batazor commented Apr 16, 2023

close #9991

@batazor
Copy link
Contributor

batazor commented Apr 16, 2023

maybe also need change a checksum in the file extra_playbooks/roles/download/defaults/main.yml

@pli01
Copy link
Contributor Author

pli01 commented Apr 16, 2023

maybe also need change a checksum in the file extra_playbooks/roles/download/defaults/main.yml

i m not sure but not needed to change extra_playbook

extra_playbooks/roles seems to be a link to roles/download/defaults/main.yml

https://github.com/kubernetes-sigs/kubespray/blob/master/extra_playbooks/roles

@pli01
Copy link
Contributor Author

pli01 commented Apr 16, 2023

Someone know why pull-kubespray-yamllint is in Waiting for status to be reported ?
and how can we replay this part to play all checks without "writes" ?

@yankay
Copy link
Member

yankay commented Apr 17, 2023

Thanks @pli01
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2023
@cyclinder
Copy link
Contributor

Thanks! @pli01

/lgtm

@oomichi
Copy link
Contributor

oomichi commented Apr 17, 2023

Thanks for doing this.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, pli01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit e907d55 into kubernetes-sigs:master Apr 17, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants