Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Update dns-autoscaler #9996

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[feature] Update dns-autoscaler #9996

merged 1 commit into from
Apr 24, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Apr 17, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Remove deprecated annotation seccomp.security.alpha.kubernetes.io/pod
  • Update cluster-proportional-autoscaler container to version 1.8.6

Does this PR introduce a user-facing change?:

Update dns-autoscaler configuration and remove deprecated annotations

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2023
@MrFreezeex
Copy link
Member

It should be updated soon (hopefully) to 1.8.8 kubernetes/k8s.io#5086 so maybe we should try to wait a bit more for this new release if it comes soon enough?

@mzaian
Copy link
Contributor Author

mzaian commented Apr 17, 2023

It should be updated soon (hopefully) to 1.8.8 kubernetes/k8s.io#5086 so maybe we should try to wait a bit more for this new release if it comes soon enough?

Fine for me, we can wait.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2023
floryut
floryut approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzaian Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mzaian
Copy link
Contributor Author

mzaian commented Apr 24, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
MrFreezeex
MrFreezeex approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D
/lgtm

@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4deeaba into kubernetes-sigs:master Apr 24, 2023
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@mzaian @pedromcpedro
[feature] Update dns-autoscaler (kubernetes-sigs#9996)
6857b4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@bozzo bozzo Awaiting requested review from bozzo

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzaian @MrFreezeex @k8s-ci-robot @floryut