Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cri-o] Bump versions to 1.26.3, 1.25.3, 1.24.5 #9999

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[cri-o] Bump versions to 1.26.3, 1.25.3, 1.24.5 #9999

merged 1 commit into from
Apr 25, 2023

Conversation

dkasanic
Copy link
Contributor

@dkasanic dkasanic commented Apr 19, 2023 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it: cri-o supported versions updated to newest verisons

Which issue(s) this PR fixes:

Fixes #9998

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[cri-o] Bump versions to 1.26.3, 1.25.3, 1.24.5

@dkasanic
[cri-o] Bump versions to 1.26.3, 1.25.3, 1.24.5
7deeaa8 
Signed-off-by: Kasanic, Denis <denisx.kasanic@intel.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dkasanic. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2023
@floryut floryut added kind/container-managers Containers section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Apr 19, 2023
floryut
floryut approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkasanic Thank you 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkasanic, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@dkasanic
Copy link
Contributor Author

/retest

@dkasanic
Copy link
Contributor Author

Hello, @floryut I think the CI failures was a flake this time, tried to retest but commnad did not work. Could you help me with this?

@floryut
Copy link
Member

floryut commented Apr 21, 2023

Hello, @floryut I think the CI failures was a flake this time, tried to retest but commnad did not work. Could you help me with this?

All good 👍

@dkasanic
Copy link
Contributor Author

pinging @floryut for approval :)

@oomichi
Copy link
Contributor

oomichi commented Apr 24, 2023

Thanks for your contribution.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit f9f5143 into kubernetes-sigs:master Apr 25, 2023
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@dkasanic @pedromcpedro
[cri-o] Bump versions to 1.26.3, 1.25.3, 1.24.5 (kubernetes-sigs#9999)
7984b24 
Signed-off-by: Kasanic, Denis <denisx.kasanic@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump cri-o versions to 1.26.3, 1.25.3, 1.24.5
4 participants
@dkasanic @k8s-ci-robot @floryut @oomichi