-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flavors with matching names should have identical labels/taints #59
Comments
I would add that the ResourceFlavor shouldn't be mandatory. OTOH, that means that we should proceed with scheduling even if we can't find a matching ResourceFlavor object. This can lead to jobs scheduling on flavors they shouldn't, specially during restarts. Is this acceptable? |
Are we settled on having a ResourceFlavor CRD? |
I think we should do that, yes. |
/assign |
/unassign leaving this for now (feel free to take it) |
/assign |
I would delay this until after 0.0.1; I think it is more important to focus on testing and verifying scale now. |
A capacity can borrow resources from flavors matching the names of ones defined in the capacity. Those flavors with matching names should also have identical labels and taints.
One solution is to define a cluster-scoped object API that represents resource flavors that capacities refer to by name when setting a quota. It would look like this:
This will avoid duplicating labels/taints on each capacity and so makes it easier to create a cohort of capacities with similar resources.
The downside is of course now we have another resource that the batch admin needs to deal with. But I expect that the number of flavors will typically be small.
The text was updated successfully, but these errors were encountered: