Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto gridify large table #5306

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

myan9
Copy link
Contributor

@myan9 myan9 commented Aug 4, 2020

This PR auto-gridify tables with more than 20 rows

Fixes #5305

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@myan9 myan9 requested a review from starpit as a code owner August 4, 2020 14:36
Copy link
Contributor

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #5306 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5306   +/-   ##
=======================================
  Coverage   59.74%   59.74%           
=======================================
  Files          78       78           
  Lines        2539     2539           
  Branches      627      627           
=======================================
  Hits         1517     1517           
  Misses        788      788           
  Partials      234      234           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016b3b0...082dd99. Read the comment docs.

@starpit starpit merged commit bd22fa2 into kubernetes-sigs:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto gridify large table
2 participants