repospec: support ssh urls with ssh certificates #4986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4741
With all the work we've put into RepoSpec lately, this is now much easier to do.
Copying that PR's description:
Docs for the SSH Certificate feature are here: https://docs.github.com/en/enterprise-cloud@latest/organizations/managing-git-access-to-your-organizations-repositories/about-ssh-certificate-authorities#about-ssh-urls-with-ssh-certificates
We can see in the git documentation that the username segment is universally valid for the ssh protocol and the scp-like format: https://git-scm.com/docs/git-fetch#_git_urls. We could validate against it being used with other protocols, but falling back on the leave-validation-to-git stance, I'm inclined not to. (Yes, this is a reversal of my stance on the original PR. I've learned a lot about RepoSpec in the interim!)