Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return error instead of log.Fatalf() #5625

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix: return error instead of log.Fatalf() #5625

merged 3 commits into from
Apr 18, 2024

Conversation

chansuke
Copy link
Member

This is a follow up PR of #5381 (comment)

Replace log.Fatalf() and return error.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2024
@chansuke chansuke force-pushed the fix/avoid-uging-logfatal branch 2 times, most recently from fc707ee to b072a9d Compare March 27, 2024 10:01
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2024
@chansuke chansuke force-pushed the fix/avoid-uging-logfatal branch 8 times, most recently from c711fff to 3ad43a2 Compare March 29, 2024 04:15
koba1t
koba1t requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@koba1t koba1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @chansuke

Thanks for your contribution!
I added a few comments to address minor points. Could you please check them?

api/internal/accumulator/namereferencetransformer_test.go Outdated Show resolved Hide resolved
api/internal/accumulator/resaccumulator_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2024
@chansuke chansuke requested a review from koba1t April 6, 2024 15:01
koba1t
koba1t requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@koba1t koba1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chansuke
This PR looks almost good to me!

I added a few minor comments that improve when any tests fail.
Could you check the below comments?

api/resource/resource_test.go Outdated Show resolved Hide resolved
api/resource/resource_test.go Outdated Show resolved Hide resolved
api/resource/resource_test.go Outdated Show resolved Hide resolved
api/resource/factory_test.go Outdated Show resolved Hide resolved
api/resource/factory_test.go Outdated Show resolved Hide resolved
@chansuke
Copy link
Member Author

@koba1t
I appreciate so much for your feedback!!
I've fixed them.

@chansuke chansuke requested a review from koba1t April 18, 2024 10:14
@koba1t
Copy link
Member

koba1t commented Apr 18, 2024

Thanks @chansuke

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2024
@koba1t
Copy link
Member

koba1t commented Apr 18, 2024

/tide merge-method-squash

@koba1t koba1t added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chansuke, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ed09399 into kubernetes-sigs:master Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba1t koba1t koba1t approved these changes

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@koba1t koba1t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chansuke @k8s-ci-robot @koba1t