Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Support self compose without *-compose #607

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 24, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #600

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Container startup no longer depend on *-compose, setting env KWOK_CONTAINER_SELF_COMPOSE=false can rollback to using *-compose.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2023
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 814519f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6487ecc6abef9f00088b4957

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2023
@wzshiming wzshiming changed the title Support no compose [WIP] Support no compose May 24, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@wzshiming wzshiming force-pushed the feat/no-compose branch 20 times, most recently from 2ad18ad to 48ce34c Compare May 24, 2023 10:45
@wzshiming wzshiming force-pushed the feat/no-compose branch 17 times, most recently from 281edb6 to d50713b Compare June 7, 2023 03:03
@wzshiming wzshiming changed the title [WIP] [kwokctl] Support self compose [WIP] [kwokctl] Support self compose without *-compose Jun 7, 2023
@wzshiming wzshiming changed the title [WIP] [kwokctl] Support self compose without *-compose [kwokctl] Support self compose without *-compose Jun 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@wzshiming wzshiming force-pushed the feat/no-compose branch 5 times, most recently from 6102727 to da43a29 Compare June 12, 2023 15:37
@wzshiming wzshiming merged commit 6374ae6 into kubernetes-sigs:main Jun 13, 2023
@wzshiming wzshiming deleted the feat/no-compose branch June 13, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kwokctl] Add docker/nerdctl/podman runtime without *-compose
2 participants