-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support record and replay #834
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for k8s-kwok canceled.
|
f046ce7
to
7e3991a
Compare
7e3991a
to
e2d7783
Compare
e2d7783
to
e6101e0
Compare
c75a3fd
to
16f3da8
Compare
5b6dff7
to
9b2a628
Compare
6874f4d
to
729c744
Compare
9d014f9
to
32a01a9
Compare
32a01a9
to
569b39e
Compare
783250f
to
6a83395
Compare
6a83395
to
f8c8d8e
Compare
3240cc6
to
bd2b512
Compare
0dceb06
to
939c014
Compare
939c014
to
df25dd0
Compare
@wzshiming: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Verifying that the replay experience on apiserver is not good, try to bypass it and directly modify the etcd data to achieve it #880 |
@@ -65,3 +65,18 @@ func MappingFor(restMapper meta.RESTMapper, resourceOrKindArg string) (*meta.RES | |||
|
|||
return mapping, nil | |||
} | |||
|
|||
// MappingForResources is a wrapper of MappingFor. | |||
func MappingForResources(restMapper meta.RESTMapper, filters []string) ([]*meta.RESTMapping, []error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we support resources' short name like kubectl
for filter
( or fucntion MappingFor
)?( e.g. pod, po, pods all works in kubectl)
For better and easier to use as a CLI tool, I think this is worth to support. I can raise a issue and subsequent PR to track this enhancement if that makes sense to you.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Move to #880 /close |
@wzshiming: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #833
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: