Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support record and replay #834

Closed
wants to merge 1 commit into from

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Nov 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #833

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support record and replay

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit df25dd0
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6582e4af48e3040008361c04

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2023
@wzshiming wzshiming changed the title Support record and replay [WIP] Support record and replay Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 13, 2023
@wzshiming wzshiming force-pushed the feat/record-replay branch 3 times, most recently from f046ce7 to 7e3991a Compare November 13, 2023 07:50
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 23, 2023
@wzshiming wzshiming force-pushed the feat/record-replay branch 2 times, most recently from c75a3fd to 16f3da8 Compare November 27, 2023 11:58
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 27, 2023
@wzshiming wzshiming force-pushed the feat/record-replay branch 7 times, most recently from 5b6dff7 to 9b2a628 Compare November 28, 2023 12:16
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 1, 2023
@wzshiming wzshiming force-pushed the feat/record-replay branch 2 times, most recently from 9d014f9 to 32a01a9 Compare December 1, 2023 18:29
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2023
@wzshiming wzshiming force-pushed the feat/record-replay branch 4 times, most recently from 783250f to 6a83395 Compare December 7, 2023 08:15
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@wzshiming wzshiming force-pushed the feat/record-replay branch 3 times, most recently from 3240cc6 to bd2b512 Compare December 12, 2023 06:19
@wzshiming wzshiming force-pushed the feat/record-replay branch 2 times, most recently from 0dceb06 to 939c014 Compare December 20, 2023 12:55
@k8s-ci-robot
Copy link
Contributor

@wzshiming: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kwok-unit-test-main df25dd0 link true /test pull-kwok-unit-test-main
pull-kwok-verify-main df25dd0 link true /test pull-kwok-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming
Copy link
Member Author

Verifying that the replay experience on apiserver is not good, try to bypass it and directly modify the etcd data to achieve it #880

@@ -65,3 +65,18 @@ func MappingFor(restMapper meta.RESTMapper, resourceOrKindArg string) (*meta.RES

return mapping, nil
}

// MappingForResources is a wrapper of MappingFor.
func MappingForResources(restMapper meta.RESTMapper, filters []string) ([]*meta.RESTMapping, []error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we support resources' short name like kubectl for filter( or fucntion MappingFor)?( e.g. pod, po, pods all works in kubectl)
For better and easier to use as a CLI tool, I think this is worth to support. I can raise a issue and subsequent PR to track this enhancement if that makes sense to you.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wzshiming
Copy link
Member Author

Move to #880

/close

@k8s-ci-robot
Copy link
Contributor

@wzshiming: Closed this PR.

In response to this:

Move to #880

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kwokctl: Support record and replay
3 participants