bump dependencies #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go: upgraded golang.org/x/exp v0.0.0-20230807204917-050eac23e9de => v0.0.0-20240506185415-9bf2ced13842 go: upgraded golang.org/x/mod v0.14.0 => v0.17.0 go: upgraded golang.org/x/sync v0.5.0 => v0.7.0 go: upgraded golang.org/x/tools v0.16.1 => v0.21.0 This fixes (at least for me) a crash when checking csi-lib-utils when using Kubernetes 1.30 there (kubernetes-sigs#28).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
This issue is currently awaiting triage. If logtools contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
pohly
force-pushed
the
dependency-update
branch
2 times, most recently
from
5df9f4f
to
6351c22
Compare
The newer version is required when checking packages which need Go 1.22. From a csi-lib-utils CI run with Go 1.22.2 in the PATH and Kubernetes 1.30 in vendor: /home/prow/go/src/github.com/kubernetes-csi/csi-lib-utils/vendor/k8s.io/apimachinery/pkg/api/resource/amount.go:17:1: package requires newer Go version go1.22 This feels like a workaround and raises the question whether this has to be done for each new Go release. Discussed in golang/go#67282. It is unclear whether building with older Go releases still works. The GitHub workflow failed while installing the older Go, without any error message.
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
Building with older Go still works: $ PATH=/nvme/gopath/go-1.21.0/bin/:$PATH go install sigs.k8s.io/logtools/logcheck@main
go: downloading sigs.k8s.io/logtools v0.8.2-0.20240510103400-c99b00396295
go: sigs.k8s.io/logtools@v0.8.2-0.20240510103400-c99b00396295 requires go >= 1.22; switching to go1.22.3
go: downloading go1.22.3 (linux/amd64)
go: downloading golang.org/x/tools v0.21.0
go: downloading golang.org/x/exp v0.0.0-20240506185415-9bf2ced13842
go: downloading golang.org/x/sync v0.7.0
go: downloading golang.org/x/mod v0.17.0$ PATH=/nvme/gopath/go-1.20.0/bin/:$PATH go install sigs.k8s.io/logtools/logcheck@main
go: downloading sigs.k8s.io/logtools v0.8.2-0.20240510103400-c99b00396295
go: downloading golang.org/x/tools v0.21.0
go: downloading golang.org/x/exp v0.0.0-20240506185415-9bf2ced13842
go: downloading golang.org/x/sync v0.7.0
go: downloading golang.org/x/mod v0.17.0Go 1.20 simply builds it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go: upgraded golang.org/x/exp v0.0.0-20230807204917-050eac23e9de => v0.0.0-20240506185415-9bf2ced13842
go: upgraded golang.org/x/mod v0.14.0 => v0.17.0
go: upgraded golang.org/x/sync v0.5.0 => v0.7.0
go: upgraded golang.org/x/tools v0.16.1 => v0.21.0
This fixes (at least for me) a crash when checking csi-lib-utils when using Kubernetes 1.30 there
Fixes: #28
It also bumps the Go version in go.mod to 1.22.2. This turned out be necessary because of golang/go#67282.
It is unclear whether building logtools with Go < 1.22 still works. The GitHub actions failed to install older Go without any error message.
cc @jsafrane @bells17