Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis/nfd: fix incorrect comments of matching functions #1467

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Nov 20, 2023

This patch updates the comments to correspond to the actual behavior which was changed back in 36341bf.

This patch updates the comments to correspond to the actual behavior
which was changed back in 36341bf.
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 9cbe742
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/655b162f13dbad0008d29054
😎 Deploy Preview https://deploy-preview-1467--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Nov 20, 2023

/assign @ArangoGutierrez

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64e848d14a6833715a90886becffeb4127a24977

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #1467 (9cbe742) into master (c588371) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1467   +/-   ##
=======================================
  Coverage   30.55%   30.55%           
=======================================
  Files          58       58           
  Lines        7527     7527           
=======================================
  Hits         2300     2300           
  Misses       4978     4978           
  Partials      249      249           
Files Coverage Δ
pkg/apis/nfd/v1alpha1/expression.go 70.87% <ø> (ø)

@k8s-ci-robot k8s-ci-robot merged commit 74c5780 into kubernetes-sigs:master Nov 20, 2023
12 checks passed
@marquiz marquiz deleted the devel/api-comments branch November 20, 2023 12:27
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants