-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis/nfd: fix incorrect comments of matching functions #1467
apis/nfd: fix incorrect comments of matching functions #1467
Conversation
This patch updates the comments to correspond to the actual behavior which was changed back in 36341bf.
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @ArangoGutierrez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 64e848d14a6833715a90886becffeb4127a24977
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1467 +/- ##
=======================================
Coverage 30.55% 30.55%
=======================================
Files 58 58
Lines 7527 7527
=======================================
Hits 2300 2300
Misses 4978 4978
Partials 249 249
|
This patch updates the comments to correspond to the actual behavior which was changed back in 36341bf.