nfd-topology-updater add pods fingerprint by default

[leemingeer]

Fixes:#1559

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	b6d8ce7
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65b381a76570070008f17bc7
😎 Deploy Preview	https://deploy-preview-1560--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Welcome @leemingeer!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @leemingeer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marquiz]

Thanks @leemingeer for the patch.

If we want to change the default, we should change the default setting of the cmdline flag (cmd/nfd-topology-updater/main.go), adapt the Helm chart, if needed, and also change the documentation (cmdline reference, Helm parameters).

/cc @PiotrProkop @ffromani

[ffromani]

for context, we set the -pods-fingerprint defaulting to false to maximize the backward compatibility. Besides a minimal extra computational cost, there's no any issue ever reporte concrerning this functionality, so switching the default to true is fine to me, it's a good time to turn on by default.

[marquiz]

Thanks @ffromani, sounds plausible to me. I'm good with changing the default

[leemingeer]

Thanks @leemingeer for the patch.

If we want to change the default, we should change the default setting of the cmdline flag (cmd/nfd-topology-updater/main.go), adapt the Helm chart, if needed, and also change the documentation (cmdline reference, Helm parameters).

/cc @PiotrProkop @ffromani

@marquiz thanks for your suggestions, i'v committed new patch. podSetFingerprint is already set to true in the values file and i believe there is no need to do chart adaption, right?

[PiotrProkop]

@leemingeer you need to modify helm chart so one can disable this feature, cause right now It will be always enabled 😄
https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/deployment/helm/node-feature-discovery/templates/topologyupdater.yaml#L69

[marquiz]

@leemingeer thanks for the update, looks good.

Took a quick look at the Helm chart and we need to adapt that, too, e.g. topology-updater template, the values.yaml and the also the parameter un docs/deployment/helm

[leemingeer]

@PiotrProkop @marquiz yes, you are right, thanks.
the updated patch has committed, please review.

[marquiz]

Thanks @leemingeer! Looks good to me

/assign @PiotrProkop

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leemingeer, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/ok-to-test

[leemingeer]

/cc @PiotrProkop @ffromani

[PiotrProkop]

/lgtm

Thanks @leemingeer !

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6d7ecc559b7e9b195b944825d963a2f48af50a0c

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea4504a) 31.07% compared to head (b6d8ce7) 33.11%.
Report is 18 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   31.07%   33.11%   +2.04%     
==========================================
  Files          61       62       +1     
  Lines        7779     8101     +322     
==========================================
+ Hits         2417     2683     +266     
- Misses       5117     5149      +32     
- Partials      245      269      +24     

Files	Coverage Δ
cmd/nfd-topology-updater/main.go	48.64% <100.00%> (ø)

... and 8 files with indirect coverage changes