-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Generate sbom on release #646
WIP - Generate sbom on release #646
Conversation
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Welcome @ricardoapl! |
Hi @ricardoapl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardoapl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub recommends setting minimum token permissions for the GITHUB_TOKEN
. Although unlikely, there is a chance that when a new job is added to this workflow, its job permissions could be left undefined because of human error. We can prevent that by setting permissions definitions as read-only at the top level.
It's not clear to me how we should go about signing SBOMs. KEP-3031: Signing release artifacts doesn't seem to apply outside of k/k, and there's also an open discussion at kubernetes/release#2286. I suggest we tackle signing SBOMs in a separate pull request. What do you think? |
/triage accepted |
Maybe not worth pursuing this given that prometheus-adapter will be archived? |
/close This is not relevant anymore as discussed in #638 |
@ricardoapl: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Generate an SBOM for each new release of prometheus-adapter
Part of #638