-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require_self_approval: true
should prevent suggesting PR author for approval
#175
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Approver logic is tricky but filtering out author name from the list of options does not seem too scary, so let's try marking it as a good first issue. I hope I'm not throwing someone under the bus 😬 |
Hey @BenTheElder @petr-muller can I look into this issue? also if yes then can you suggest me some steps to get started on this? |
require_self_approval: true
should prevent suggesting PR author for approval
@Bharadwajshivam28 Sure, feel free to give it a shot! Here are some breadcrumbs. The problem is that Prow sometimes asks The message seems to be built here from a prow/pkg/plugins/approve/approvers/owners.go Lines 685 to 691 in 24e7653
I retitled this issue to mention the |
[This is re-filed from https://github.com/kubernetes/test-infra/issues/29827]
What happened:
TLDR in a repo with implicit_self_approval off, prow will sometimes suggest the author as the approver, it should suggest someone else.
https://kubernetes.slack.com/archives/CDECRSC5U/p1669738130214399
What you expected to happen:
suggest non-pr-author for finding an approver
How to reproduce it (as minimally and precisely as possible):
.... you'll need implicit_self_approval disabled, yourself in OWNERS, and then file a PR until this happens.
Please provide links to example occurrences, if any:
lots of sample links in the slack thread linked above
Anything else we need to know?:
/sig testing
The text was updated successfully, but these errors were encountered: