Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a presubmit job triggered builds on draft pull requests #190

Open
ivanvc opened this issue Jun 12, 2024 · 1 comment
Open

Renaming a presubmit job triggered builds on draft pull requests #190

ivanvc opened this issue Jun 12, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ivanvc
Copy link

ivanvc commented Jun 12, 2024

Background Slack threads: #sig-testing, #prow.

As part of etcd's migration to the prow infrastructure, I recently renamed an etcd presubmit job (pull-etcd-unit-test to pull-etcd-unit-test-amd64) in kubernetes/test-infra#32708. After merging this pull request, it triggered jobs in many pull requests.

However, it seems like the status reconciler may have a bug, as it also ran on draft pull requests. An example is etcd-io/etcd#14094: prow job

Here's the list of the jobs it ran; the ones before Jun 05 17:20:00 were automatically triggered after the renaming:
https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-etcd-unit-test-amd64?buildId=1798872340767969280

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2024
@petr-muller petr-muller added kind/bug Categorizes issue or PR as related to a bug. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants