Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker files to use buildx to support multiple Windows OS #123

Closed
jsturtevant opened this issue Nov 6, 2020 · 4 comments
Closed

Comments

@jsturtevant
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Build upon #111 to convert the dockerfiles to use buildx so we can build versions for supported Windows OS's. This would solve #93 and #90

References:
pause image: https://github.com/kubernetes/kubernetes/blob/9a57dc20a98dcc7a6b2bd1323d4e27f84477cd1b/build/pause/Dockerfile_windows
test images: kubernetes/kubernetes#93889

Describe the solution you'd like
A clear and concise description of what you want to happen.

There would be the following images:

sigwindowstools/flannel:v0.12 (multi arch manifest that points to the latest of the following images)

sigwindowstools/flannel:v0.12-2019-{build_tag}

sigwindowstools/flannel:v0.12-1909-{build_tag}

sigwindowstools/flannel:v0.12-2004-{build_tag}

sigwindowstools/flannel:v0.13 (multi arch manifest that points to the latest of the following images)

sigwindowstools/flannel:v0.13-2019-{build_tag}

sigwindowstools/flannel:v0.13-1909-{build_tag}

sigwindowstools/flannel:v0.13-2004-{build_tag}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Setting up windows servers for each version. This requires to much maintenance and costs.

Additional context
Add any other context or screenshots about the feature request here.

@vitaliy-leschenko
Copy link
Contributor

I did it! @jsturtevant please re-review last changes at #111

@vitaliy-leschenko
Copy link
Contributor

I added kubeproxy images for all windows server versions also in #111.

@jsturtevant
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants